Some minor remarks/suggestions on #18 #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 13 13
Lines 306 306
=======================================
Hits 275 275
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
reviewed
Jun 26, 2024
Comment on lines
+14
to
+22
|
|
||
| # Example | ||
| ```julia | ||
| nhs_trivial = TrivialNeighborhoodSearch ....... | ||
|
|
||
| ... | ||
|
|
||
| nhs_grid = GridNeighborhoodSearch .... | ||
| ``` |
There was a problem hiding this comment.
I didn't add an example because this benchmark is mostly to be used with plot_benchmarks.
efaulhaber
reviewed
Jun 26, 2024
Comment on lines
+39
to
+40
| # Is there a reason why this is hard coded? Why not passing custom nhs like `custom_nhs...`? | ||
| # And then `nameof(typeof(nhs))` |
There was a problem hiding this comment.
- You would have to pass an array of functions
(search_radius, coordinates) -> nhs, which would get ugly quickly. nameof(typeof(nhs))is not enough. With new backends and options, many of these names will be "SomeNeighborhoodSearchwithsome_option=true".
I figured it is easier to treat this like an example file that you modify and include again.
|
@LasNikas Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor remarks/suggestions on #18