Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add damping force and allow selecting the faces to create for the rectangular setup #41

Merged
merged 59 commits into from
Jan 14, 2023
Merged

Add damping force and allow selecting the faces to create for the rectangular setup #41

merged 59 commits into from
Jan 14, 2023

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Jan 4, 2023

  • Add simple damping force term to accelerate getting to an initial at rest state
  • Allow selecting the faces that are created for the "rectangular tank setup"

@svchb
missing dependency
0fb2bb7
@svchb
revert
fbb2846
@svchb
add vtk save
c856745
@svchb
switch to single floats to save memory for output
7ff2167
@svchb
add examples project definition
f94103c
@svchb
switch back to 4th order RK for presimulation
33e4cd3
@svchb
add damping force
f44849f
@svchb
add some more output
3c0bf75
@svchb
set damping coefficient
a59054e
@svchb
allow changing the damping coefficient
1965da3
@svchb
Merge branch 'pixie-framework:dev' into dev
04632b3
@svchb
select faces to create
784b2ef
@svchb
Merge branch 'pixie-framework:dev' into dev
6317793
@svchb
Merge branch 'dev' of https://github.com/svchb/Pixie.jl into dev
db6df62
@svchb
merge upstream
10c070e
@svchb
Merge branch 'dev' into main
e79f9ff
@svchb
merge
e0955b2
@svchb
remove project.toml from examples
d4cd9be
@svchb
fix 3d case
e0eda5f
@svchb
update examples
4b3ed24
@svchb
update examples
c796bf0
@svchb
Merge branch 'main' of https://github.com/svchb/Pixie.jl
73195d9
@svchb
revert unintended change
45af485
@svchb
merge main
434d1ee
@svchb svchb requested a review from efaulhaber January 5, 2023 20:05
efaulhaber
efaulhaber requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! Faster relaxing is definitely helpful, especially with higher fluid resolutions. The faces are great for more flexibility.

examples/fluid/dam_break_2d.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_2d.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_2d.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_2d.jl Outdated Show resolved Hide resolved
examples/fluid/dam_break_3d.jl Outdated Show resolved Hide resolved
src/semidiscretization/semidiscretization.jl Outdated Show resolved Hide resolved
src/containers/fluid_container.jl Outdated Show resolved Hide resolved
src/setups/rectangular_tank.jl Outdated Show resolved Hide resolved
src/setups/rectangular_tank.jl Outdated Show resolved Hide resolved
src/util.jl Outdated Show resolved Hide resolved
@efaulhaber
Copy link
Member

efaulhaber commented Jan 6, 2023 •
edited
Loading

I just checked, and I can't see any difference with and without relaxing. Am I doing something wrong?

Edit: Now, I tried a very large coefficient of 100.0, and it worked pretty nicely. In the relaxing step, the water immediately freezes in a position where it doesn't bounce when I restart the dam break without damping. That's really cool!

LasNikas
LasNikas reviewed Jan 8, 2023
View reviewed changes
src/semidiscretization/semidiscretization.jl Outdated Show resolved Hide resolved
src/setups/rectangular_tank.jl Outdated Show resolved Hide resolved
efaulhaber
efaulhaber requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor remarks.

examples/fluid/dam_break_3d.jl Show resolved Hide resolved
examples/fluid/falling_water_column_2d.jl Outdated Show resolved Hide resolved
src/semidiscretization/semidiscretization.jl Outdated Show resolved Hide resolved
src/semidiscretization/semidiscretization.jl Outdated Show resolved Hide resolved
src/semidiscretization/semidiscretization.jl Outdated Show resolved Hide resolved
@efaulhaber
Copy link
Member

The tank looks like this now with different faces missing. There are no overlapping particles.
image
image
image
image
image
image
image
image
image
image
image
image

@efaulhaber efaulhaber closed this Jan 12, 2023
@efaulhaber efaulhaber reopened this Jan 12, 2023
efaulhaber
efaulhaber requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more minor detail, then we're ready to merge.

src/semidiscretization/semidiscretization.jl Outdated Show resolved Hide resolved
efaulhaber
efaulhaber previously approved these changes Jan 13, 2023
View reviewed changes
@svchb svchb merged commit 2ed2e49 into trixi-framework:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LasNikas LasNikas LasNikas left review comments

@sloede sloede sloede left review comments

@efaulhaber efaulhaber efaulhaber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svchb @efaulhaber @sloede @LasNikas