-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for GPU support #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 68.73% 68.73%
=======================================
Files 86 86
Lines 5278 5278
=======================================
Hits 3628 3628
Misses 1650 1650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svchb
requested changes
Nov 12, 2024
svchb
requested changes
Nov 14, 2024
svchb
approved these changes
Nov 14, 2024
LasNikas
approved these changes
Nov 14, 2024
LasNikas
pushed a commit
to LasNikas/TrixiParticles.jl
that referenced
this pull request
Nov 18, 2024
* Add docs for GPU support * Reformat code * Implement suggestions * Implement suggestions * Fix typo
LasNikas
pushed a commit
to LasNikas/TrixiParticles.jl
that referenced
this pull request
Nov 18, 2024
* Add docs for GPU support * Reformat code * Implement suggestions * Implement suggestions * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added an example test for the hydrostatic water column with the
FullGridCellList
, which tests the code that I added in the docs.And I addressed point 7 of #627.
Find the rendered docs for this PR here:
https://trixi-framework.github.io/TrixiParticles.jl/previews/PR660/