Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix citations #428

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Fix citations #428

merged 7 commits into from
Sep 4, 2024

Conversation

kazymovae
Copy link
Contributor

Enhancements:

  • Updated the convert_to_bibtex_format method to default to 'book' if the type is not specified.

Bug Fixes:

  • Resolved the SocketError: getaddrinfo: nodename nor servname provided to enhance stability and prevent network-related errors during execution.
  • Fixed test cases for hathi_links_grouped_by_oclc_number and ia_ids_grouped_by_class, ensuring all tests pass successfully.

Updates:

  • Updated to use 'rspec-rails', '~> 6' to align with recent changes and improve compatibility with newer Rails versions.
  • Changed config.fixture_path to config.fixture_paths as part of the migration to Rails 7.2. A comment was added to provide clarification on this change.

@seanaery seanaery merged commit 2009645 into main Sep 4, 2024
8 checks passed
@seanaery seanaery deleted the Fix-citations branch September 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants