Patch accessibility issues within TomSelect checkboxes rendered in Ad… #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vanced Search multi-select. - Note the checkboxes are added via the "checkbox_options" plugin; the markup it renders is not configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vanced Search multi-select.
These revisions satisfy WAVE testing when options for a given multi-select are displaying. Axe DevTools will still report an issue about nested interactive elements (i.e., there's a checkbox element inside of an element serving as a form option), however the attributes added via these changes should be correctly indicating the checkbox's presentational nature.
Before
After