Fix as_dict for arrays #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the field is an array, then the field type will not have the as_dict method bound to it. The Structure describing the individual elements in the array will have the as_dict method. Because of this, hasattr(type_, "as_dict") will always return False.
faisal-shah
force-pushed
the
fix/as_dict-for-arrays
branch
from
bfd6b42
to
494b836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the field is an array, then the field type will not have the as_dict method bound to it. The Structure describing the individual elements in the array will have the as_dict method. Because of this, hasattr(type_, "as_dict") will always return False.