Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying existing plugin to work with Grails 2.4.3 #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomwallace
Copy link

The existing plugin did not work because of the change of referencing ApplicationContext and other static Holder classes to use the new grails.util.Holders instead. To make the changes, we created a new plugin using the current grails version and migrated the existing plugin classes and tests over there. At this point, the code compiles and the tests run.

…ails version (2.4.3). The existing plugin did not work because of the change of referencing ApplicationContext and other static Holder classes to use the new grails.util.Holders instead. To make the changes, we created a new plugin using the current grails version and migrated the existing plugin classes and tests over there. At this point, the code compiles and the tests run.
@johntdyer
Copy link
Member

@tomwallace - thanks !
@mpermar - can you please take a look at this PR ?

…is now an InputStream rather than a JSON object, as it used to work for a successful submittal. This caused the plugin to throw an exception, as the logic to determine if the submittal was successful assumed the response would either be a map or a JSON object. We modified the expectation so that it only trys to use the put method if the resulting object was a map. This fixed the plugin in our application.
@tomwallace
Copy link
Author

Hello. We found an additional issue when testing the modified version of the plugin in this pull request with our application. I am pushing those changes into my repo now, which should already be shared via the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants