Modifying existing plugin to work with Grails 2.4.3 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails version (2.4.3). The existing plugin did not work because of the change of referencing ApplicationContext and other static Holder classes to use the new grails.util.Holders instead. To make the changes, we created a new plugin using the current grails version and migrated the existing plugin classes and tests over there. At this point, the code compiles and the tests run.
|
@tomwallace - thanks ! |
…is now an InputStream rather than a JSON object, as it used to work for a successful submittal. This caused the plugin to throw an exception, as the logic to determine if the submittal was successful assumed the response would either be a map or a JSON object. We modified the expectation so that it only trys to use the put method if the resulting object was a map. This fixed the plugin in our application.
|
Hello. We found an additional issue when testing the modified version of the plugin in this pull request with our application. I am pushing those changes into my repo now, which should already be shared via the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing plugin did not work because of the change of referencing ApplicationContext and other static Holder classes to use the new grails.util.Holders instead. To make the changes, we created a new plugin using the current grails version and migrated the existing plugin classes and tests over there. At this point, the code compiles and the tests run.