【腾讯犀牛鸟开源课题实战】对接mysql sdk（主框架变动部分） #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weimch
reviewed
Nov 15, 2024
weimch
reviewed
Nov 15, 2024
weimch
reviewed
Nov 19, 2024
trpc/client/service_proxy.h
Outdated
| @@ -118,9 +118,18 @@ class ServiceProxy { | |||
| /// in the options for non-direct connection models. | |||
| const std::string& GetServiceName(); | |||
|
|
|||
| // Collect statistics on the service proxy and report them to the tvar. | |||
| void ProxyStatistics(const ClientContextPtr& ctx); | |||
There was a problem hiding this comment.
为啥要调整位置呢，原来的接口声明放置位置看上去没啥问题，文件的改动应该只需要在 Init 和 Destroy 前加上virtual，其他不需要改，只改Init和Destroy的话，commit数量是不是有点过多了，能不能只提一个commit
There was a problem hiding this comment.
因为ProxyStatistics是在ServiceProxy的接口里面调用的，还有CheckTimeout，但继承后不走那个接口。
KosmosFult
force-pushed
the
mysql-main-repo
branch
from
620a1b6 to
5578377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue
MySQL相关protocol和config相关