NAS-128710 / 24.04.1 / Add migrations for SMB-related fields #13643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the DragonFish release we removed the clustering feature from TrueNAS. In prior versions we had some SMB share presets that were exposed only to clustering users via the webui, but were still accessible via the API. These presets existed for TrueCommand purposes to simplify cluster share creation. Unfortunately, some users may have set these via our APIs on non-clustered shares, and so this commit adds a migration to convert them to an appropriate SMB share configuration post-Cobia. Due to a longstanding bug in SCALE, there were circumstances in which pam_mkhomedir would create the directory `/nonexistent` when users had SMB homes shares. Starting in dragonfish / is readonly with the result that the pam_session for users with a home directory of `/nonexistent` to fail, resulting in SMB access being rejected in "obey pam restrictions" is set. This commit adds a migration to force home directories of SMB users to change to /var/empty if it was set to /nonexistent.
bugclerk
changed the title
themylogin
approved these changes
May 1, 2024
mgrimesix
approved these changes
May 1, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the DragonFish release we removed the clustering feature from TrueNAS. In prior versions we had some SMB share presets that were exposed only to clustering users via the webui, but were still accessible via the API. These presets existed for TrueCommand purposes to simplify cluster share creation. Unfortunately, some users may have set these via our APIs on non-clustered shares, and so this commit adds a migration to convert them to an appropriate SMB share configuration post-Cobia.
Due to a longstanding bug in SCALE, there were circumstances in which pam_mkhomedir would create the directory
/nonexistentwhen users had SMB homes shares. Starting in dragonfish / is readonly with the result that the pam_session for users with a home directory of/nonexistentto fail, resulting in SMB access being rejected in "obey pam restrictions" is set. This commit adds a migration to force home directories of SMB users to change to /var/empty if it was set to /nonexistent.