NAS-129867 / 24.10 / setup HA middleware connection on service restart #13971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
bmeagherix
approved these changes
Jul 3, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security requirements dictate that we should stop binding our internal HA connection on 0.0.0.0 so we did just that here: #13830. However, often times our developers (and our CI/CD) will
systemctl restart middlewaredroutinely. When this happens, we don't re-bind the HA connection. This fixes that scenario so that we always re-bind on service restart.NOTE: When this happens on a running HA machine, the local and remote sessions from BEFORE the service restart go into a
TIME_WAITstatus and will eventually be reaped by the kernel (as expected).