Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-129946 / 24.10 / clean up API quota tests #13987

Merged
merged 2 commits into from
Jul 8, 2024
Merged

NAS-129946 / 24.10 / clean up API quota tests #13987

merged 2 commits into from
Jul 8, 2024

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Jul 8, 2024

  1. test_340 was wholly unnecessary since all of the behavior in that file is tested exhaustively in other test modules.
  2. test_810 is a dead test and serves no purpose. The shareuser is kept within 1 test file
  3. I combined the quota test from test_340 and the test from test_pool_dataset_set_quota into 1 file test_quotas.py

@yocalebo yocalebo added the jira label Jul 8, 2024
@yocalebo yocalebo requested a review from a team July 8, 2024 11:10
@bugclerk bugclerk changed the title Clean up1 NAS-129946 / 24.10 / Clean up1 Jul 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129946

@yocalebo yocalebo changed the title NAS-129946 / 24.10 / Clean up1 clean up API quota tests Jul 8, 2024
@bugclerk bugclerk changed the title clean up API quota tests NAS-129947 / 24.10 / clean up API quota tests Jul 8, 2024
@yocalebo yocalebo changed the title NAS-129947 / 24.10 / clean up API quota tests NAS-129946 / 24.10 / clean up API quota tests Jul 8, 2024
@truenas truenas deleted a comment from bugclerk Jul 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129946

@yocalebo yocalebo merged commit 31ec7f1 into master Jul 8, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the clean-up1 branch July 8, 2024 11:15
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qubad786 Qubad786 Qubad786 approved these changes

Assignees
No one assigned
Labels
jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yocalebo @bugclerk @Qubad786