NAS-130271 / 24.10 / Check SnapshotCountAlert on SMB shares only #14161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
|
Do we still have some sort of alert when users are doing absurd things with snapshots? |
Yeah the alert that triggers when there's over 10,000 total snapshots is still there. |
creatorcary
changed the title
creatorcary
force-pushed
the
NAS-130271
branch
2 times, most recently
from
30d1a73 to
2892e16
Compare
yocalebo
requested changes
Aug 8, 2024
yocalebo
reviewed
Aug 8, 2024
yocalebo
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Excellent! Please wait for @anodos325 approval before merge.
anodos325
reviewed
Aug 9, 2024
anodos325
requested changes
Aug 9, 2024
anodos325
approved these changes
Aug 9, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alert should only be checked for relevant datasets: those that are shared over SMB. The limit of 512 snapshots only applies due to Windows File Explorer limiting the number of snapshots shown in the Previous Versions tab.
I have also changed the alert description to more precisely describe the problem.
Relevant documentation
withAPI tests