Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130495 / 24.10 / Add support for deploying custom apps #14167

Merged
merged 20 commits into from
Aug 9, 2024
Merged

NAS-130495 / 24.10 / Add support for deploying custom apps #14167

merged 20 commits into from
Aug 9, 2024

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Aug 8, 2024

This PR adds support for a custom app which essentially will be a custom provided docker compose file from the user.

@sonicaj sonicaj self-assigned this Aug 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Aug 8, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130495

@bugclerk bugclerk changed the title Add support for deploying custom apps NAS-130495 / 24.10 / Add support for deploying custom apps Aug 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Aug 8, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-130495

@sonicaj sonicaj force-pushed the custom-app-support branch from de5cf0e to 0ee6836 Compare August 8, 2024 07:53
sonicaj added 19 commits August 8, 2024 20:06
@sonicaj
Rename ix-chart to ix-app
2dace0d
@sonicaj
Fix app.available
e00faeb
@sonicaj
Add basic custom app svc
bfa4e40
@sonicaj
Call app.custom.create if custom app creation is desired
f2187fb
@sonicaj
Add basic validation for app.custom.create
b329c1e
@sonicaj
Expect serialized yaml file for docker compose
b780c73
@sonicaj
Allow specifying both string/dict for custom compose config
3c6509e
@sonicaj
Modify setup install app util to account for custom app
f26ef22
@sonicaj
Amend updating config func to account for custom apps
b50a18f
@sonicaj
Amend metadata func to account for custom app
e727113
@sonicaj
Complete custom app create implementation:
814a251
@sonicaj
Add validation util for custom compose app
c2724fb
@sonicaj
Get updates to work for custom apps
36ea6d7
@sonicaj
Fix upgrade available flag for custom apps
7b057af
@sonicaj
Add internal endpoint for deleting app
cf52649
@sonicaj
Add util to get rendered docker compose config
d37fd66
@sonicaj
Add ability to convert any app to advanced app
dff7935
@sonicaj
Add public endpoint to convert any app to custom app
459ed78
@sonicaj
Fix minor bug
cd2636e
@sonicaj sonicaj force-pushed the custom-app-support branch from c51970f to cd2636e Compare August 8, 2024 15:07
@sonicaj sonicaj removed the WIP label Aug 8, 2024
@sonicaj sonicaj requested a review from a team August 8, 2024 15:10
yocalebo
yocalebo approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a pretty clean change. Awesome!

@sonicaj sonicaj merged commit 3696d96 into master Aug 9, 2024
1 of 3 checks passed
@sonicaj sonicaj deleted the custom-app-support branch August 9, 2024 04:20
@bugclerk
Copy link
Contributor

bugclerk commented Aug 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

Assignees

@sonicaj sonicaj

Labels
jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonicaj @bugclerk @yocalebo