-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-130507 / 24.10 / Remove legacy pool.dataset.permission endpoint #14170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Remove legacy pool.dataset.permission endpoint
NAS-130507 / 24.10 / Remove legacy pool.dataset.permission endpoint
Aug 8, 2024
anodos325
force-pushed
the
remove-pooldataset-permission
branch
4 times, most recently
from
August 9, 2024 15:15
6e82907
to
89caf9e
Compare
yocalebo
approved these changes
Aug 9, 2024
mgrimesix
approved these changes
Aug 9, 2024
bmeagherix
reviewed
Aug 9, 2024
bmeagherix
reviewed
Aug 9, 2024
This functionality has been superseded by filesystem ACL and permissions endpoints since TrueNAS 12. Endpoint is no longer used by the webui and so it is safe to remove.
anodos325
force-pushed
the
remove-pooldataset-permission
branch
from
August 9, 2024 18:48
052e17a
to
31858bf
Compare
bmeagherix
requested changes
Aug 9, 2024
bmeagherix
approved these changes
Aug 9, 2024
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality has been superseded by filesystem ACL and permissions endpoints since TrueNAS 12. Endpoint is no longer used by the webui and so it is safe to remove.