Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130507 / 24.10 / Remove legacy pool.dataset.permission endpoint #14170

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

anodos325
Copy link
Contributor

This functionality has been superseded by filesystem ACL and permissions endpoints since TrueNAS 12. Endpoint is no longer used by the webui and so it is safe to remove.

@bugclerk bugclerk changed the title Remove legacy pool.dataset.permission endpoint NAS-130507 / 24.10 / Remove legacy pool.dataset.permission endpoint Aug 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Aug 8, 2024

@anodos325 anodos325 force-pushed the remove-pooldataset-permission branch 4 times, most recently from 6e82907 to 89caf9e Compare August 9, 2024 15:15
@anodos325 anodos325 removed the WIP label Aug 9, 2024
@anodos325 anodos325 requested review from a team, bmeagherix and mgrimesix August 9, 2024 15:16
This functionality has been superseded by filesystem ACL and
permissions endpoints since TrueNAS 12. Endpoint is no longer
used by the webui and so it is safe to remove.
@anodos325 anodos325 force-pushed the remove-pooldataset-permission branch from 052e17a to 31858bf Compare August 9, 2024 18:48
tests/api2/test_347_posix_mode.py Outdated Show resolved Hide resolved
@anodos325 anodos325 merged commit d8506b9 into master Aug 9, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the remove-pooldataset-permission branch August 9, 2024 19:42
@bugclerk
Copy link
Contributor

bugclerk commented Aug 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants