NAS-133594 / 25.04 / feat: add digitalocean ACME Authenticator #15315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yocalebo
requested changes
Jan 6, 2025
t0b3
force-pushed
the
digitalocean-acme-dns-provider
branch
from
44fd7bc to
ab10992
Compare
|
@yocalebo can I add anything to get it ready to merge? I'd be happy to help 😃 |
sonicaj
reviewed
Jan 14, 2025
src/middlewared/middlewared/api/v25_04_0/acme_dns_authenticator.py
Outdated
Show resolved
Hide resolved
t0b3
force-pushed
the
digitalocean-acme-dns-provider
branch
2 times, most recently
from
e06cc3e to
152161b
Compare
|
@sonicaj here you get the adaptations as requested 👍 |
sonicaj
reviewed
Jan 14, 2025
src/middlewared/middlewared/api/v25_04_0/acme_dns_authenticator.py
Outdated
Show resolved
Hide resolved
t0b3
force-pushed
the
digitalocean-acme-dns-provider
branch
from
152161b to
8e538be
Compare
|
@sonicaj tested, works like a charm 😃 |
Closes: https://forums.truenas.com/t/add-digitalocean-as-acme-dns-authenicator/29879 Signed-off-by: Thomas Bettler <[email protected]>
t0b3
force-pushed
the
digitalocean-acme-dns-provider
branch
from
8e538be to
68baea4
Compare
|
and here some final variable name tweaking to reduce probability of future collisions |
|
FYI: I tested this with yesterdays nightly ISO preview for TrueNAS 25.04 |
bugclerk
changed the title
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds digitalocean ACME Authenticator
Closes: https://forums.truenas.com/t/add-digitalocean-as-acme-dns-authenicator/29879
cc @sonicaj