NAS-133328 / 25.04 / Use -freebsdCompat flag for sedutil-cli

[yocalebo]

sedutil-cli (by default) uses an asinine, non-portable "hashing" mechanism for the password. This means the password you typed on freeBSD to setup the drive will NOT work when given on linux (and vice versa). Since we're now stuck with this head-ache, we'll try again with the -freebsdCompat flag.

This does 3 primary things:

1. move the actual logic for unlocking a disk to utility functions inside utils/sed.py
2. if we fail to unlock a disk, try again with the -freebsdCompat flag
3. unify, simplify, and add comments todisk.sed_unlock_all and disk.sed_unlock and various other methods that I added

This has been tested on an internal system where we reproduced this issue and there are no regressions, more importantly is that disks initialized on CORE now successfully unlock on SCALE.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133328

[mgrimesix]

Flake8 complained about this:

    if (
        query_cp.returncode == ReturnCodeMappings.INVALID_OR_UNSUPPORTED
        or query_cp.returncode != ReturnCodeMappings.SUCCESS
    ):

With W503 "line break before binary operator". What you have in this PR is the current recommended line break. https://www.flake8rules.com/rules/W503.html
We might consider adding a global ignore to W503.

[yocalebo]

Flake8 complained about this:

    if (
        query_cp.returncode == ReturnCodeMappings.INVALID_OR_UNSUPPORTED
        or query_cp.returncode != ReturnCodeMappings.SUCCESS
    ):

With W503 "line break before binary operator". What you have in this PR is the current recommended line break. https://www.flake8rules.com/rules/W503.html We might consider adding a global ignore to W503.

Yeah, I agree

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.