Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133520 / 25.04 / Allow configurable endpoints for TNC #15389

Merged
merged 10 commits into from
Jan 15, 2025
Merged

NAS-133520 / 25.04 / Allow configurable endpoints for TNC #15389

merged 10 commits into from
Jan 15, 2025

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Jan 14, 2025

No description provided.

@sonicaj sonicaj self-assigned this Jan 14, 2025
@bugclerk bugclerk changed the title Allow configurable endpoints for TNC NAS-133520 / 25.04 / Allow configurable endpoints for TNC Jan 14, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133520

@sonicaj sonicaj requested review from ZackaryWelch and a team January 14, 2025 16:34
yocalebo
yocalebo requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, we're being too complicated with the schema validation logic.

@sonicaj sonicaj requested a review from yocalebo January 15, 2025 08:47
yocalebo
yocalebo approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonicaj sonicaj merged commit a869aac into master Jan 15, 2025
2 checks passed
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 15, 2025
@sonicaj sonicaj deleted the NAS-133520 branch January 15, 2025 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yocalebo yocalebo yocalebo approved these changes

@ZackaryWelch ZackaryWelch ZackaryWelch approved these changes

Assignees

@sonicaj sonicaj

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sonicaj @bugclerk @ZackaryWelch @yocalebo