Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133544 / 25.04 / Delete fcport target mapping on target delete #15391

Merged
merged 3 commits into from
Jan 14, 2025
Merged

NAS-133544 / 25.04 / Delete fcport target mapping on target delete #15391

merged 3 commits into from
Jan 14, 2025

Conversation

bmeagherix
Copy link
Contributor

@bmeagherix bmeagherix commented Jan 14, 2025 •
edited
Loading

  • When deleting a target remove any corresponding fcport mapping. (Fixes foreign key constraint failure.)
  • Add test_target_delete to test deletion of a mapped fibre channel target

Passing (abridged) CI run here.

@bugclerk bugclerk changed the title NAS-133544 NAS-133544 / 25.04 / NAS-133544 Jan 14, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133544

@bmeagherix bmeagherix changed the title NAS-133544 / 25.04 / NAS-133544 NAS-133544 / 25.04 / Delete fcport target mapping on target delete Jan 14, 2025
@bmeagherix bmeagherix requested a review from a team January 14, 2025 20:03
mgrimesix
mgrimesix approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@mgrimesix mgrimesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include confirmation of port status.

@bmeagherix bmeagherix merged commit dfb44e7 into master Jan 14, 2025
2 checks passed
@bmeagherix bmeagherix deleted the NAS-133544 branch January 14, 2025 20:55
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgrimesix mgrimesix mgrimesix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmeagherix @bugclerk @mgrimesix