NAS-132865 / 25.04 / Clean up old validation for keychaincredential, make API definitions more precise
#15392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
keychaincredential, make API definitions more precisekeychaincredential, make API definitions more precise
yocalebo
reviewed
Jan 14, 2025
themylogin
reviewed
Jan 14, 2025
| type: str | ||
| attributes: Secret[dict] | ||
| """Distinguishes this Keychain Credential from others.""" | ||
| type: Literal["SSH_KEY_PAIR", "SSH_CREDENTIALS"] |
There was a problem hiding this comment.
Can we move type inside attributes and use the more native discriminator approach? Basically, the same thing that's already done for cloud credentials.
There was a problem hiding this comment.
This would change the schema of most of our keychaincredential endpoints which are used in too many places to make this change worth it given that using a discriminated union would only slightly make our validation more performant. If we make this change in the future it should be its own PR.
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve readability of our docs and move away from our old schema definitions/validation.
http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/2608/