Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133695 / 25.04 / Disable authorization check for system.hostname #15451

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

anodos325
Copy link
Contributor

Midcli and potentially other tools check system.hostname and will fail in STIG mode or when crendential doesn't have FULL_ADMIN RBAC role. This commit changes the endpoint so that any authenticated session can request the system hostname.

Midcli and potentially other tools check system.hostname and
will fail in STIG mode or when crendential doesn't have
FULL_ADMIN RBAC role. This commit changes the endpoint so
that any authenticated session can request the system
hostname.
@anodos325 anodos325 requested a review from yocalebo January 21, 2025 14:49
@bugclerk bugclerk changed the title Disable authorization check for system.hostname NAS-133695 / 25.04 / Disable authorization check for system.hostname Jan 21, 2025
@bugclerk
Copy link
Contributor

@anodos325 anodos325 merged commit 21b2b89 into master Jan 21, 2025
2 checks passed
@anodos325 anodos325 deleted the fix-system-hostname-stig branch January 21, 2025 14:51
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants