NAS-133708 / 25.04 / Convert job ID to uuid #15454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
force-pushed
the
convert-job-id-to-uuid
branch
from
b027f7c to
4c7850c
Compare
In some CI runs it was observed that unexpected results were being returned for middleware jobs. This commit converts our job ids from being monotonically incrementing integer to proper uuid so that the job id that client is trying to track is guaranteed to uniquely identify it regardless of which HA node is being connected to.
anodos325
force-pushed
the
convert-job-id-to-uuid
branch
from
4c7850c to
98e4448
Compare
bmeagherix
approved these changes
Jan 21, 2025
yocalebo
reviewed
Jan 21, 2025
| @@ -291,7 +289,7 @@ def __init__(self, middleware, method_name, serviceobj, method, args, options, p | |||
| self.app = app | |||
| self.audit_callback = audit_callback | |||
|
|
|||
| self.id = None | |||
| self.id = int(uuid4()) | |||
There was a problem hiding this comment.
You can do self.id = uuid4().int
There was a problem hiding this comment.
@undsoft will such long ints work well with JSON?
>>> uuid4().int
311364041177499672922985169261652976368
>>> uuid4().int
262998890057434762054815435825767399766
>>> uuid4().int
106487518651827065074465048916488123677
There was a problem hiding this comment.
I was hemming and hawing about that one. I may make it a string rather than number (e.g. "106487518651827065074465048916488123677") to make random JSON libraries happier. UI seems to not worry about consuming UUIDs here (nothing broke in an obvious way) as either a number or a string.
|
I would fix the client so it forgets all jobs when the connection is re-established. |
It's hard to control how clients will behave (outside of our own). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some CI runs it was observed that unexpected results were being returned for middleware jobs. This commit converts our job ids from being monotonically incrementing integer to proper uuid so that the job id that client is trying to track is guaranteed to uniquely identify it regardless of which HA node is being connected to.