NAS-133717 / 25.04 / Properly compare helm secrets version numbers #15459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
yocalebo
requested changes
Jan 22, 2025
src/middlewared/middlewared/plugins/kubernetes_to_docker/secrets_utils.py
Outdated
Show resolved
Hide resolved
stavros-k
approved these changes
Jan 22, 2025
Qubad786
force-pushed
the
mrehan/properly-compare-helm-versions
branch
from
1f6db07 to
f9ea7d8
Compare
yocalebo
approved these changes
Jan 22, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when comparing Helm secret versions, the comparison is being performed as strings. This causes issues with two-digit versions not being compared correctly, leading to older app versions being migrated instead of the correct ones.
Solution
Resolve this issue by converting the Helm version strings into integers before performing the comparison. This ensures accurate version comparisons during app migration.