Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133739 / 25.04 / fix pool.dataset.details validation #15466

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

yocalebo
Copy link
Contributor

Trying to specify all of the fields in this endpoint is proving to be very finicky. Since we're freezing for BETA, let's error on side of caution and have a loose annotation (instead of trying to be narrow).

@yocalebo yocalebo requested a review from a team January 23, 2025 16:12
@bugclerk bugclerk changed the title fix pool.dataset.details validation NAS-133739 / 25.04 / fix pool.dataset.details validation Jan 23, 2025
@bugclerk
Copy link
Contributor

@yocalebo yocalebo merged commit b040cd6 into master Jan 23, 2025
2 checks passed
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 23, 2025
@yocalebo yocalebo deleted the NAS-133739 branch January 23, 2025 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants