NAS-133766 / 25.04 / Improve validation for virt volumes #15474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
sonicaj
approved these changes
Jan 24, 2025
|
This PR has been merged and conversations have been locked. |
yocalebo
reviewed
Jan 24, 2025
| @@ -46,6 +48,11 @@ async def query(self, filters, options): | |||
| async def do_create(self, data): | |||
| await self.middleware.call('virt.global.check_initialized') | |||
|
|
|||
| verrors = ValidationErrors() | |||
| if await self.middleware.call('virt.volume.query', [['id', '=', data['name']]]): | |||
| verrors.add('virt_volume_create.name', 'Volume with this name already exists') | |||
There was a problem hiding this comment.
Just import ValidationError and raise it here instead of creating a verrors object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We improve validation when creating/importing virt volumes here so that we can raise errors in a meaningful way.