Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132231 / 25.10 / Schema + documentation for API events #15478

Merged
merged 6 commits into from
Jan 28, 2025
Merged

NAS-132231 / 25.10 / Schema + documentation for API events #15478

merged 6 commits into from
Jan 28, 2025

Conversation

themylogin
Copy link
Contributor

No description provided.

@themylogin themylogin requested a review from a team January 24, 2025 13:56
@themylogin
Copy link
Contributor Author

time 12:00

@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132231

@bugclerk bugclerk changed the title Schema + documentation for API events NAS-132231 / 25.04 / Schema + documentation for API events Jan 24, 2025
@themylogin
Copy link
Contributor Author

We need change every event_register call with events = [...] in service config @yocalebo

@yocalebo
Copy link
Contributor

We need change every event_register call with events = [...] in service config @yocalebo

Will middleware break if we merge these changes without doing it?

@themylogin
Copy link
Contributor Author

We need change every event_register call with events = [...] in service config @yocalebo

Will middleware break if we merge these changes without doing it?

No, this is the same gradual conversion process.

@yocalebo yocalebo requested a review from creatorcary January 24, 2025 14:28
@yocalebo yocalebo changed the title NAS-132231 / 25.04 / Schema + documentation for API events NAS-132231 / 25.10 / Schema + documentation for API events Jan 27, 2025
@themylogin themylogin merged commit a47e579 into master Jan 28, 2025
2 checks passed
@themylogin themylogin deleted the NAS-132231 branch January 28, 2025 08:43
@bugclerk bugclerk mentioned this pull request Jan 28, 2025
Merged
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-132231 is targeted to the following versions which have not received their corresponding PRs: 25.10

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creatorcary creatorcary creatorcary approved these changes

@yocalebo yocalebo yocalebo approved these changes

@anodos325 anodos325 Awaiting requested review from anodos325

Assignees
No one assigned
Labels
backport-25.04-RC.1 backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themylogin @bugclerk @yocalebo @creatorcary