NAS-133834 / 25.04-RC.1 / Ensure we populate node_name and parent_host for NPIV (by bmeagherix) #15496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8b05e53)
bmeagherix
approved these changes
Jan 27, 2025
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we populate
node_nameandparent_hostfor NPIV targets, even if the physical port does not have a target mapped to it.Without this SCST could fail to start under certain configurations.
Rename
ha_node_wwpn_for_fcporttoha_node_wwpn_for_fcport_or_fchostto properly the two types of parameters that it can (now) be called with.CI run here.
Original PR: #15495
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133834