Improve MongoDB connection string matching #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
force-pushed
the
feat/mongodb-regex
branch
3 times, most recently
from
ee65d94
to
284590e
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
284590e
to
a6652c0
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
2 times, most recently
from
7f1b02e
to
ff9db3a
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
2 times, most recently
from
707b6bd
to
daf8947
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
daf8947
to
c36c649
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
2 times, most recently
from
add3140
to
b6ceaa2
Compare
|
@zricethezav this should be ready for review now. |
rgmz
force-pushed
the
feat/mongodb-regex
branch
2 times, most recently
from
8f434af
to
c71f2d7
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
c71f2d7
to
1963c0c
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
3 times, most recently
from
f2732cf
to
159f012
Compare
2 tasks
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
159f012
to
b3eefba
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
b3eefba
to
cbfa5dd
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
3 times, most recently
from
3ac447e
to
6b52a69
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
2 times, most recently
from
99d7bf9
to
4005150
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
3 times, most recently
from
b98c69e
to
e547cf5
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
2 times, most recently
from
234c262
to
3e7540d
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
3e7540d
to
4a2d134
Compare
rgmz
force-pushed
the
feat/mongodb-regex
branch
from
4a2d134
to
8f0059c
Compare
ahrav
approved these changes
Sep 23, 2024
pkg/detectors/mongodb/mongodb.go
Outdated
| if !isErrDeterminate(err) { | ||
| isVerified, verificationErr := verifyUri(ctx, resMatch, timeout) | ||
| s1.Verified = isVerified | ||
| if !isErrDeterminate(verificationErr) { | ||
| s1.SetVerificationError(err, resMatch) |
There was a problem hiding this comment.
nit: I think this should be verificationErr.
There was a problem hiding this comment.
It absolutely should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly fixes #1512, although it would be valuable to add real secrets to test verification of multiple hosts, connection options, etc.