Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analyzer] Test and generated permissions for HuggingFace, Square & Stripe #3294

Conversation

abmussani
Copy link
Contributor

@abmussani abmussani commented Sep 13, 2024

Description:

This PR includes test and generated enumerated permissions for HuggingFace, Square & Stripe Analyzers.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@abmussani abmussani requested a review from a team as a code owner September 13, 2024 15:15
@abmussani abmussani changed the title [Analyzer] Test and generated permissions for HuggingFace and Square [Analyzer] Test and generated permissions for HuggingFace, Square & Stripe Sep 13, 2024
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment on lines 1 to 7
permissions:
- BANK_ACCOUNTS_READ
- APPOINTMENTS_WRITE
- APPOINTMENTS_ALL_WRITE
- APPOINTMENTS_READ
- APPOINTMENTS_ALL_READ
- APPOINTMENTS_BUSINESS_SETTINGS_READ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why these are all capitalized? I don't recall any other analyzer doing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I copied it from somewhere. You are right, all of our analyzers have permissions in small caps. Let me change this one in the name of consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcastorina updated the permissions with small caps for consistency.

@mcastorina mcastorina merged commit 3e46b3f into trufflesecurity:main Sep 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants