Endpoint customizer refresh #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add CloudProvider interface.
rgmz
reviewed
Sep 19, 2024
zricethezav
reviewed
Sep 23, 2024
rosecodym
approved these changes
Sep 23, 2024
mcastorina
reviewed
Sep 23, 2024
zricethezav
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated Endpoint Customizer and Detectors using it.
This change separates configuration for using found URLs in the data and using known cloud URLs, while centralizing the logic for detectors to use in the
EndpointSetterstruct. The driving force for this change is that we have some URLs known ahead of time and some URLs known only at detection time, and we would like to configure both.The embeddable
EndpointSetterstruct has a simplified interface: A detector callss.Endpoints(foundURLs...)to get a slice of the endpoints to perform verification against.A
CloudProviderinterface is also introduced in this PR for a detector to signal there is a cloud endpoint associated with it.Checklist:
make test-community)?make lintthis requires golangci-lint)?