-
Notifications
You must be signed in to change notification settings - Fork 1
Add deployed field with capture variable, multiple networks #1
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,38 @@ | ||||||
version: 0.0.1 | ||||||
description: declarative deployment file "declarative deployments for Truffle projects | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the purpose of this description field? |
||||||
# put npm packages needed for deployment here | ||||||
require: ["dotenv"] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure this belongs here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how do you see the flow for requiring external packages? do you not think it should be in the declaration yaml file? this was a first pass at doing that |
||||||
# organize by network, then by | ||||||
fainashalts marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
deployed: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ I know there was conversation around potentially letting users define various states: ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that is reasonable. Then the initial solver can just deal with the base state of |
||||||
mainnet: | ||||||
SafeMathLib: | ||||||
arguments: | ||||||
- SafeMathLib | ||||||
- options: | ||||||
gasPrice: 15000000 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
capture: | ||||||
- address: "$.address" | ||||||
as: "SafeMathLibAddress" | ||||||
# can also optionally transform the captured variable; | ||||||
# wouldn't do toString() here, just an example | ||||||
transform: "this.SafeMathLibAddress.toString()" | ||||||
# can capture multiple variables | ||||||
- transactionHash: "$.transactionHash" | ||||||
as: "SafeMathLibTransactionHash" | ||||||
# stop execution and error if we don't get the variable | ||||||
# setting to false would mean we continue without it | ||||||
strict: true | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎨 Not super opinionated here, but between There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I agree! It feels clearer. I think @gnidan had advocated for loose. Open to discussing it of course! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we make the |
||||||
Escrow: | ||||||
arguments: | ||||||
- Escrow | ||||||
links: ["SafeMathLib"] | ||||||
arbitrum_mainnet: | ||||||
HumanStandardToken: | ||||||
# setting ifTrue tells the solver not to proceed with this deployment unless | ||||||
# we have the designated capture variable. ifTrue could also be a list/array | ||||||
ifTrue: SafeMathLibAddress | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ Since we will be supporting
|
||||||
arguments: | ||||||
- HumanStandardToken | ||||||
# and here is how we would then use the captured variable | ||||||
- "{{ SafeMathLibAddress }}" | ||||||
- "{{ SafeMathLibTransactionHash }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this version field refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the version of the DApp? I guess we should talk about what versions of what need to be indicated here.