Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bump ethpm-registry version. #3148

Closed

Conversation

nebojsa94
Copy link
Contributor

The current version of ethpm-registry dependency has unused native modules.

I'll update the version in package.json once trufflesuite/ethpm-registry#9 is merged and released

@iainjreid
Copy link

Thanks for referencing the issue @nebojsa94, another small step towards removing those old dependencies!

@eggplantzzz
Copy link
Contributor

@nebojsa94 Thanks for the PR! I don't think we want this pulled in directly from GitHub. This week I'll go ahead and merge a couple of outstanding PRs and publish it. Then we can bump it normally. Sound ok to you?

@nebojsa94
Copy link
Contributor Author

@eggplantzzz Of course, hence the draft status. As I mentioned in the description, I'll update the package.json once the package is released, can we proceed with the merge trufflesuite/ethpm-registry#9?

@eggplantzzz
Copy link
Contributor

eggplantzzz commented Jul 8, 2020

@nebojsa94 @iainjreid Just merged and published ethpm-registry version 0.0.11! Go ahead and update this PR and we'll get it merged hopefully to release this week. Thanks for the help folks! Much obliged

@nebojsa94 nebojsa94 force-pushed the v4-remove-native-dependencies branch from 07a830d to dc0ed58 Compare July 9, 2020 12:03
@nebojsa94 nebojsa94 force-pushed the v4-remove-native-dependencies branch from dc0ed58 to b0b98e5 Compare July 9, 2020 12:12
@nebojsa94 nebojsa94 marked this pull request as ready for review July 9, 2020 13:07
@eggplantzzz
Copy link
Contributor

Unfortunately it looks like there is some issue in CI. We'll need to take a closer look before merging this.

@eggplantzzz
Copy link
Contributor

Oh whoops, I just realized that this is targeting branch v4. Sorry but v4 is no longer being maintained. Are you interested in making this PR against develeop (currently version 5)?

@nebojsa94
Copy link
Contributor Author

Sure, can we first merge #3156

@eggplantzzz eggplantzzz changed the base branch from v4 to develop July 10, 2020 18:02
@eggplantzzz eggplantzzz changed the base branch from develop to v4 July 10, 2020 18:02
@eggplantzzz
Copy link
Contributor

I made a comment over on that PR!

@nebojsa94
Copy link
Contributor Author

@eggplantzzz Thanks, closing this one.

@nebojsa94 nebojsa94 closed this Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants