Skip to content

Commit

Permalink
Merge pull request #38 from trussworks/mb-13104
Browse files Browse the repository at this point in the history
[MB-13104] Documentation updates to reflect new anti-virus source
  • Loading branch information
chtakahashi authored Jul 27, 2022
2 parents f18b6b1 + 4fca996 commit 4cfb1fd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 11 deletions.
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
repos:
- repo: git://github.com/pre-commit/pre-commit-hooks
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.0.1
hooks:
- id: check-json
Expand All @@ -11,12 +11,12 @@ repos:
- --autofix
- id: trailing-whitespace

- repo: git://github.com/igorshubovych/markdownlint-cli
- repo: https://github.com/igorshubovych/markdownlint-cli
rev: v0.28.1
hooks:
- id: markdownlint

- repo: git://github.com/antonbabenko/pre-commit-terraform
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.50.0
hooks:
- id: terraform_docs
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@
# terraform-aws-s3-anti-virus

Creates an AWS Lambda function to do anti-virus scanning of objects in AWS S3
using [bucket-antivirus-function](https://github.com/upsidetravel/bucket-antivirus-function)
using [bucket-antivirus-function](https://github.com/trussworks/bucket-antivirus-function)

While waiting for updates on that repo you will need to use a special fork and branch:
The source repository hasn't been updated in a long time, so we've forked the repo to our account and made changes.

```sh
git clone [email protected]:upsidetravel/bucket-antivirus-function.git
git clone [email protected]:trussworks/bucket-antivirus-function.git
cd bucket-antivirus-function
git checkout v2.0.0
git checkout v2.2.0
```

With that repo checked out you must run the `make` command and then copy the resulting zip file
to AWS S3 with:

```sh
VERSION=2.0.0
VERSION=2.2.0
aws s3 cp bucket-antivirus-function/build/lambda.zip "s3://lambda-builds-us-west-2/anti-virus/${VERSION}/anti-virus.zip"
```

Expand Down
3 changes: 0 additions & 3 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ variable "timeout_seconds" {
default = 300
}

#
# The variables below correspond to https://github.com/upsidetravel/bucket-antivirus-function/tree/master#configuration
#
variable "av_definition_s3_bucket" {
description = "Bucket containing antivirus database files."
type = string
Expand Down

0 comments on commit 4cfb1fd

Please sign in to comment.