Skip to content

Commit

Permalink
Merge pull request #34 from trustpilot/decouple-ui
Browse files Browse the repository at this point in the history
Decouple ui
  • Loading branch information
halfzebra authored Jul 10, 2017
2 parents 4d1f127 + fef006f commit ef19892
Show file tree
Hide file tree
Showing 18 changed files with 489 additions and 10,571 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ before_script:

script:
- npm run ci:travis
- npm run build:prod

after_success:
- npm run semantic-release
24 changes: 22 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,32 @@
# Development

When developing, it's preferable to run in test mode:
Thanks for for the interest in contributing to Skift!

Please read this document to learn how to work this project.

## Commiting new code

Skift is released automatically with [semantic-release.](https://github.com/semantic-release/semantic-release)

We use [Commitizen](https://github.com/commitizen/cz-cli) to ensure the quality of commit messages, please provide the maximum amount of details about your commit.

To commit your code run:

```bash
npm run cz
```

## Running Skift it test mode

When developing, it's preferable to run the project in test mode:

```
npm test
```

## Build a new release
## Building a distribution for the new release

The following command will produce the development and minified versions of Skift distribution in `dist/` folder.

```
npm run build:prod
Expand Down
8 changes: 8 additions & 0 deletions config/webpack.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ module.exports = {
library: 'skift',
libraryTarget: 'umd'
},
externals: {
jquery: {
commonjs: 'jquery',
commonjs2: 'jquery',
amd: 'jquery',
root: 'jQuery'
}
},
resolve: {
extensions: ['.ts', '.js'],
modules: ['node_modules']
Expand Down
14 changes: 7 additions & 7 deletions config/webpack.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ module.exports = {
entry: {
skift: './src/index.ts'
},
output: {
path: path.resolve(__dirname, '../dist'),
filename: '[name].min.js',
sourceMapFilename: '[name].source.map',
library: 'skift',
libraryTarget: 'umd'
},
externals: {
jquery: {
commonjs: 'jquery',
Expand All @@ -14,13 +21,6 @@ module.exports = {
root: 'jQuery'
}
},
output: {
path: path.resolve(__dirname, '../dist'),
filename: '[name].min.js',
sourceMapFilename: '[name].source.map',
library: 'skift',
libraryTarget: 'umd'
},
resolve: {
extensions: ['.ts', '.js'],
modules: ['node_modules']
Expand Down
Loading

0 comments on commit ef19892

Please sign in to comment.