Skip to content

Commit

Permalink
coverage: ignore lcov errors temporarily
Browse files Browse the repository at this point in the history
problem: we seem to get spurious branch merge mismatch errors in CI, and
ensuring atomicity has not helped

solution: ignore all lcov errors with GCOV_ERROR_FILE=/dev/null

We can't ignore that specific class of errors with `--ignore-errors
mismatch` because our lcov version is too low, and increasing the
version is not an easy option in el8.

fixes flux-framework#6078
  • Loading branch information
trws committed Aug 5, 2024
1 parent 6896c72 commit 315ebe2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ CODE_COVERAGE_IGNORE_PATTERN = \
"*/common/libccan/*" \
"*/common/libmissing/*"

# ignore lcov errors to avoid merge mismatch issue since lcov < 2 doesn't offer
# an option to just ignore this error, we use this env var to ignore all, see:
# https://github.com/flux-framework/flux-core/issues/6078
export GCOV_ERROR_FILE=/dev/null
CODE_COVERAGE_LCOV_OPTIONS =
@CODE_COVERAGE_RULES@

Expand Down

0 comments on commit 315ebe2

Please sign in to comment.