Merge pull request #134 from anas-sarkez/main

Render pin labels for the PinHeader component in SVG
tscircuit · Nov 19, 2024 · c6f40db · c6f40db
2 parents 0425ab9 + f4dabba
commit c6f40db
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/lib/sch/svg-object-fns/create-svg-objects-for-sch-port-pin-label.ts b/lib/sch/svg-object-fns/create-svg-objects-for-sch-port-pin-label.ts
@@ -42,7 +42,7 @@ export const createSvgObjectsForSchPortPinLabel = (params: {
 
   const label =
     schPort.display_pin_label ??
-    schComponent.port_labels?.[`pin${schPort.pin_number}`]
+    schComponent.port_labels?.[`${schPort.pin_number}`]
 
   if (!label) return []
 

diff --git a/tests/sch/__snapshots__/kicad-theme-demo.snap.svg b/tests/sch/__snapshots__/kicad-theme-demo.snap.svg
diff --git a/tests/sch/kicad-theme-demo.test.tsx b/tests/sch/kicad-theme-demo.test.tsx
@@ -23,7 +23,24 @@ it("example 4: kicad theme demo", async () => {
         schX={2}
       />
       <trace from=".R1 > .pin2" to=".C1 > .pin1" />
-
+      <pinheader
+        name="pin1"
+        schX={0}
+        schY={-2}
+        pinCount={10}
+        pinLabels={[
+          "pin1",
+          "pin2",
+          "pin3",
+          "pin4",
+          "pin5",
+          "pin6",
+          "pin7",
+          "pin8",
+          "pin9",
+          "pin10",
+        ]}
+      />
       <chip
         name="U2"
         manufacturerPartNumber="ATmega8-16A"