-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 3d Rendering via 3d-viewer with SvgRenderer #166
base: main
Are you sure you want to change the base?
Conversation
…ts ./lib/3d/svg-object-fns/`
… ./lib/3d/components/`
this fix missing green fr4 <board>
* update toolchains * update lock file * pin github:tscircuit/3d-viewer to specific tag/version
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gonna create an issue on how to refactor @tscircuit/3d-viewer so the renderer can be swapped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrSensor please rssolve conflicts
@techmannih no need to review for things like conflicts, linting etc. while a PR is in draft! drsensor is a smart guy i think he's still putting together the PR |
This is looking great, before we merge we may want to do a quick bundle size comparison. I'm also wondering if we can avoid the patches to the libraries. |
the patch in as for oh wait, this might work. bundle it before running the |
Oh another random note, one way we can avoid messing up servers that use circuit-to-svg etc. is by having this being another export, so we could have people who want to use 3d stuff do That would be nice because we do render a lot of svgs on the server for snippets! |
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
90626cd
to
d7d3579
Compare
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
cde1b4a
to
626decf
Compare
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch)
|
@DrSensor curious how this PR is going, we're using SVGs in all of our docs now and I think it'd be sick to have 3d as a selectable option- i would even default to 3d being the default tab a lot of the time |
it should be okay now to use on server-side despite some bundler trick in vite.config.js 😅 Lines 55 to 57 in fd2e2d7
|
close #138
/claim #138
Warning
This draft has some sorcery. (review with caution!)
if Copilot (or other AI) hallucinated, try: git blame, https://githistory.xyz, or https://semanticdiff.com
Important
server side usage require DOM emulation
usage