initial: cloud autorouter on group #495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
reviewed
Jan 9, 2025
| @@ -38,7 +39,7 @@ export class Group<Props extends z.ZodType<any, any, any> = typeof groupProps> | |||
|
|
|||
| get config() { | |||
| return { | |||
| zodProps: groupProps as unknown as Props, | |||
| zodProps: subcircuitGroupProps as unknown as Props, | |||
There was a problem hiding this comment.
Could we use z.union here? (Maybe itll mess something up?)
There was a problem hiding this comment.
Actually it should be conditional on the subscircuit prop
|
|
||
| // Create a basic circuit that needs routing | ||
| circuit.add( | ||
| <group autorouter={"auto-cloud" as any}> |
There was a problem hiding this comment.
Suggested change
| <group autorouter={"auto-cloud" as any}> | |
| <group autorouter={"auto-cloud"} subcircuit /> |
|
@seveibar it worked lol, that was unclear and shouldn't it be a subcircuit by default? |
|
Well subcircuit has really big effects and a group is more or less a container that is harmless by default. We are going to introduce a |
|
@seveibar I guess you can close the issue now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to approach this, the problem is that zod doesn't register the autorouter prop since it is not defined in groupProps but in subcircuitGroupProps
I also need to update the types in props repo that's why I have as any in the test but that's not a difficult
/claim #453
/closes #453