feat: Introduce <stampboard /> #637
Open
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShiboSoftwareDev
requested changes
Feb 18, 2025
imrishabh18
requested changes
Feb 18, 2025
Comment on lines
+37
to
+43
| const props = stampboardInstance!._parsedProps as any | ||
| expect(props.leftPinCount).toBe(4) | ||
| expect(props.rightPinCount).toBe(4) | ||
| expect(props.topPins).toEqual(["TP1", "TP2"]) | ||
| expect(props.bottomPins).toEqual(["BP1", "BP2"]) | ||
| expect(props.pinPitch).toBe(2) | ||
| expect(props.innerHoles).toBe(true) |
There was a problem hiding this comment.
Not sure why are you checking the passing props, check the circuit_json which is being rendered.
@ShiboSoftwareDev we cannot do a snapshot test because we do not have a symbol for stampboard right now?? |
|
@Anshgrover23 I'm talking about a pcb snapshot, doesn't this component implicitly create a footprint? |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #213
Fixes #213