Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSCadThreeMesh component #26

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Add JSCadThreeMesh component #26

merged 3 commits into from
Jul 22, 2024

Conversation

r-bt
Copy link
Collaborator

@r-bt r-bt commented Jul 20, 2024 •
edited
Loading

First pass at adding the JSCadThreeMesh component following #25. I broke out the code in createJSCADRenderer and jscad-fixture to a new createJSCadRenderer hook.

Some potential improvements:

  1. Switching the JsCadFixture component to use the JSCadThreeMesh component and react-three-fiber components.
  2. In another PR allowing the material to be specified as a prop on the components

Let me know what you think

seveibar
seveibar approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work- not an easy PR, i can help fix the formatting/type issues

@r-bt r-bt merged commit 3066fcb into main Jul 22, 2024
1 of 3 checks passed
This was referenced Sep 25, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-bt @seveibar