Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add fullscreen btn #166

Closed
wants to merge 4 commits into from
Closed

Feat: Add fullscreen btn #166

wants to merge 4 commits into from

Conversation

Ayushjhawar8
Copy link
Contributor

Closes #151
/claim #151

maxMinBtn.mp4

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
runframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 11:07am

@algora-pbc algora-pbc bot mentioned this pull request Jan 20, 2025
Open
@Ayushjhawar8
Copy link
Contributor Author

@imrishabh18 @seveibar please check

seveibar
seveibar reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually want to "fill the browser window" (sry bad issue description), you'll need to make an example where runframe is inside a window with e.g. a lot of padding so it's small

@Ayushjhawar8 Ayushjhawar8 changed the title Feat: Add max, min btn Feat: Add fullscreen btn Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fullscreen button
2 participants
@Ayushjhawar8 @seveibar