Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import circuit json #599

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ArnavK-09
Copy link
Contributor

@ArnavK-09 ArnavK-09 commented Jan 20, 2025

/claim #596
Fixes #596

screenshots

image

image

image

image

image

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 34.38 MB
  • After: 34.38 MB
  • Change: 📈 5.26 KB (0.01%)

Diff

Package Before After Diff Change
zod@^3.23.8 117.16 KB 113.74 KB 📉 3.42 KB
-2.92%
circuit-json@^0.0.130 226.24 KB 228.10 KB 📈 1.86 KB
0.82%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.02 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.130 228.10 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
@tscircuit/footprinter@^0.0.101 116.11 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
dsn-converter@^0.0.57 33.14 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 126.00 B
@tscircuit/core@^0.0.273 64.00 B
What is this? This is an automated bundle size report generated during the build process.


try {
jsonData = (
await axios.get(jsonUri, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the variable names are really not clear here and you should not need to call the API

But the variable names are really not good, note that the word "data" is literally a banned word https://github.com/tscircuit/handbook/blob/main/guides/code.md

src/pages/quickstart.tsx Outdated Show resolved Hide resolved
@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.50 MB
  • After: 31.50 MB
  • Change: 📈 5.43 KB (0.02%)

Diff

Package Before After Diff Change
zod@^3.23.8 117.16 KB 113.74 KB 📉 3.42 KB
-2.92%
circuit-json@^0.0.132 168.89 KB 170.63 KB 📈 1.74 KB
1.03%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.02 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.132 170.63 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
dsn-converter@^0.0.57 33.14 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
@tscircuit/schematic-viewer@^1.4.3 30.00 B
What is this? This is an automated bundle size report generated during the build process.

1 similar comment
@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.50 MB
  • After: 31.50 MB
  • Change: 📈 5.43 KB (0.02%)

Diff

Package Before After Diff Change
zod@^3.23.8 117.16 KB 113.74 KB 📉 3.42 KB
-2.92%
circuit-json@^0.0.132 168.89 KB 170.63 KB 📈 1.74 KB
1.03%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.02 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.132 170.63 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
dsn-converter@^0.0.57 33.14 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
@tscircuit/schematic-viewer@^1.4.3 30.00 B
What is this? This is an automated bundle size report generated during the build process.

Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnavK-09 also attach the screenshot because this is related to UI Design.

@ArnavK-09
Copy link
Contributor Author

@ArnavK-09 also attach the screenshot because this is related to UI Design.

attached #599 (comment)

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.50 MB
  • After: 31.50 MB
  • Change: 📈 5.45 KB (0.02%)

Diff

Package Before After Diff Change
zod@^3.23.8 117.16 KB 113.74 KB 📉 3.42 KB
-2.92%
circuit-json@^0.0.132 168.89 KB 170.63 KB 📈 1.74 KB
1.03%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.02 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.132 170.63 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
dsn-converter@^0.0.57 33.14 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
@tscircuit/schematic-viewer@^1.4.3 30.00 B
What is this? This is an automated bundle size report generated during the build process.

1 similar comment
@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.50 MB
  • After: 31.50 MB
  • Change: 📈 5.45 KB (0.02%)

Diff

Package Before After Diff Change
zod@^3.23.8 117.16 KB 113.74 KB 📉 3.42 KB
-2.92%
circuit-json@^0.0.132 168.89 KB 170.63 KB 📈 1.74 KB
1.03%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.02 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.132 170.63 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
dsn-converter@^0.0.57 33.14 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
@tscircuit/math-utils@^0.0.10 2.58 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
@tscircuit/schematic-viewer@^1.4.3 30.00 B
What is this? This is an automated bundle size report generated during the build process.

Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 25, 2025
@ArnavK-09
Copy link
Contributor Author

....

@github-actions github-actions bot removed the stale label Jan 26, 2025
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnavK-09 resolve conflicts.

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 35.58 MB
  • After: 35.59 MB
  • Change: 📈 9.11 KB (0.02%)

Diff

Package Before After Diff Change
circuit-json@^0.0.134 162.48 KB 164.47 KB 📈 1.99 KB
1.22%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1017.98 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
circuit-json@^0.0.134 164.47 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
@tscircuit/footprinter@^0.0.102 116.65 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
@tscircuit/math-utils@^0.0.10 4.57 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.61 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 126.00 B
@tscircuit/core@^0.0.287 124.00 B
dsn-converter@^0.0.57 28.00 B
What is this? This is an automated bundle size report generated during the build process.

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.47 MB
  • After: 31.48 MB
  • Change: 📈 8.94 KB (0.03%)

Diff

Package Before After Diff Change
circuit-json@^0.0.134 135.93 KB 137.75 KB 📈 1.82 KB
1.34%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.00 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
circuit-json@^0.0.134 137.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
@tscircuit/math-utils@^0.0.10 4.60 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.93 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
dsn-converter@^0.0.57 28.00 B
What is this? This is an automated bundle size report generated during the build process.

src/pages/quickstart.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments!

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.47 MB
  • After: 31.48 MB
  • Change: 📈 8.92 KB (0.03%)

Diff

Package Before After Diff Change
circuit-json@^0.0.134 135.93 KB 137.75 KB 📈 1.82 KB
1.34%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.00 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
circuit-json@^0.0.134 137.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
@tscircuit/math-utils@^0.0.10 4.60 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.93 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
dsn-converter@^0.0.57 28.00 B
What is this? This is an automated bundle size report generated during the build process.

@ArnavK-09
Copy link
Contributor Author

see comments!

i have updated code as per review, is there anything else left for merge? Thanks

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 31.47 MB
  • After: 31.47 MB
  • Change: 📈 8.28 KB (0.03%)

Diff

Package Before After Diff Change
circuit-json@^0.0.134 135.93 KB 137.75 KB 📈 1.82 KB
1.34%
View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 1018.00 KB
ms@^2.1.3 531.75 KB
posthog-js@^1.203.2 229.68 KB
tailwind-merge@^2.5.2 140.24 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.75 KB
circuit-json@^0.0.134 137.75 KB
zod@^3.23.8 113.74 KB
circuit-to-svg@^0.0.101 101.86 KB
@tscircuit/footprinter@^0.0.102 58.09 KB
react-helmet@^6.1.0 29.16 KB
@radix-ui/react-scroll-area@^1.1.0 28.88 KB
@radix-ui/react-toast@^1.2.1 25.46 KB
fflate@^0.8.2 19.90 KB
@radix-ui/react-dialog@^1.1.1 11.97 KB
@radix-ui/react-popover@^1.1.1 10.63 KB
states-us@^1.1.1 7.27 KB
react-query@^3.39.3 5.93 KB
@radix-ui/react-tabs@^1.1.0 5.62 KB
@radix-ui/react-checkbox@^1.1.1 4.94 KB
use-mouse-matrix-transform@^1.3.0 4.73 KB
react-intersection-observer@^9.14.1 4.64 KB
@tscircuit/math-utils@^0.0.10 4.60 KB
zustand@^4.5.5 4.11 KB
lucide-react@^0.445.0 3.93 KB
file-saver@^2.0.5 3.58 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
use-async-memo@^1.2.5 759.00 B
clsx@^2.1.1 723.00 B
vite@^5.4.8 644.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
dsn-converter@^0.0.57 28.00 B
What is this? This is an automated bundle size report generated during the build process.

Copy link
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnavK-09 I think we will need playwright tests for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to import circuitJson
5 participants