-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import circuit json #599
base: main
Are you sure you want to change the base?
Conversation
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
|
||
try { | ||
jsonData = ( | ||
await axios.get(jsonUri, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the variable names are really not clear here and you should not need to call the API
But the variable names are really not good, note that the word "data" is literally a banned word https://github.com/tscircuit/handbook/blob/main/guides/code.md
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
1 similar comment
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArnavK-09 also attach the screenshot because this is related to UI Design.
attached #599 (comment) |
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
1 similar comment
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArnavK-09 resolve conflicts.
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments!
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
i have updated code as per review, is there anything else left for merge? Thanks |
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArnavK-09 I think we will need playwright tests for these
/claim #596
Fixes #596
screenshots