Fix/overflow view page #164
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/PreviewContent.tsx
Outdated
| @@ -80,7 +80,7 @@ export const PreviewContent = ({ | |||
| <Tabs | |||
| value={activeTab} | |||
| onValueChange={setActiveTab} | |||
| className="flex-grow flex flex-col" | |||
| className="flex-grow flex flex-col sticky top-0 h-screen" | |||
There was a problem hiding this comment.
hmm is this needed? the container already has sticky
There was a problem hiding this comment.
Yes, that container sticky even when provided with the h-screen it doesn't make it stick. I think we can remove that div as a whole
Screen.Recording.2024-11-03.at.3.08.41.AM.mov
There was a problem hiding this comment.
it might be my computer but the videos you're posting are 0s, is it just me?
There was a problem hiding this comment.
I still don't understand what this line fixes though, it's already in a sticky container. Maybe the video would help (let me know if it's on my end)
There was a problem hiding this comment.
I think on my end, the video recorded was playing in my machine. But on the upload preview it doesn't
There was a problem hiding this comment.
Very strange. I use Kap for recording fwiw
|
@imrishabh18 future pushes will deploy the preview |
|
I want to play with this PR, for some reason the video doesn't load and I'm confused by the sticky and overflow parameters |
|
@imrishabh18 instead of having this overflow with scroll, can we make it expand to the full size of the page the same way it does on the editor page?
|
|
@seveibar You mean something like this? Screen.Recording.2024-11-03.at.3.16.52.AM.mov |
Yep! I think that is more natural- it's what github does after all! |
imrishabh18
force-pushed
the
fix/overflow-view-page
branch
from
528161f to
432e2e1
Compare
Closes - #151
Screen.Recording.2024-11-03.at.2.48.20.AM.mov