Skip to content

Commit

Permalink
Add recert hostname arg to skip control-plane revision triggers
Browse files Browse the repository at this point in the history
This change leverages recert's latest OCP post-process hostname
feature, which makes OCP's control-plane cluster operators (i.e.
etcd, kube-apiserver, kube-controller-manager, kube-scheduler)
happy, so that the latter won't trigger additional revisions. Thus
reducing the time OCP needs to stabilize after recert.

For more details please check here:
- rh-ecosystem-edge/recert#82

Signed-off-by: Michail Resvanis <[email protected]>
  • Loading branch information
mresvanis authored and tsorya committed Feb 6, 2024
1 parent 9a2d783 commit 12616aa
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/recert/recert.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type RecertConfig struct {
ForceExpire bool `json:"force_expire,omitempty"`
EtcdEndpoint string `json:"etcd_endpoint,omitempty"`
ClusterRename string `json:"cluster_rename,omitempty"`
Hostname string `json:"hostname,omitempty"`
SummaryFile string `json:"summary_file,omitempty"`
SummaryFileClean string `json:"summary_file_clean,omitempty"`
StaticDirs []string `json:"static_dirs,omitempty"`
Expand All @@ -45,6 +46,10 @@ func CreateRecertConfigFile(clusterInfo *seedreconfig.SeedReconfiguration, seedC
config.ClusterRename = fmt.Sprintf("%s:%s", config.ClusterRename, clusterInfo.InfraID)
}

if clusterInfo.Hostname != seedClusterInfo.SNOHostname {
config.Hostname = clusterInfo.Hostname
}

config.SummaryFile = SummaryFile
seedFullDomain := fmt.Sprintf("%s.%s", seedClusterInfo.ClusterName, seedClusterInfo.BaseDomain)
clusterFullDomain := fmt.Sprintf("%s.%s", clusterInfo.ClusterName, clusterInfo.BaseDomain)
Expand Down

0 comments on commit 12616aa

Please sign in to comment.