forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break formatting #917
Open
tstellar
wants to merge
7
commits into
main
Choose a base branch
from
bad-format2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Break formatting #917
Commits on Jan 13, 2024
-
Have a look at the following commit to see when the move from DWARF 4 to 5 first happened upstream: llvm@d3b26de?diff=unified
Configuration menu - View commit details
-
Copy full SHA for 035d412 - Browse repository at this point
Copy the full SHA 035d412View commit details
Commits on Jan 16, 2024
-
[workflows] Split pr-code-format into two parts to make it more secure
Actions triggered by pull_request_target events have access to all repository secrets, so it is unsafe to use them when executing untrusted code. The pr-code-format workflow does not execute any untrusted code, but it passes untrused input into clang-format. An attacker could use this to exploit a flaw in clang-format and potentially gain access to the repository secrets. By splitting the workflow, we can use the pull_request target which is more secure and isolate the issue write permissions in a separate job. The pull_request target also makes it easier to test changes to the code-format-helepr.py script, because the version of the script from the pull request will be used rather than the version of the script from main.
Configuration menu - View commit details
-
Copy full SHA for 014876f - Browse repository at this point
Copy the full SHA 014876fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed7823 - Browse repository at this point
Copy the full SHA 1ed7823View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74caf14 - Browse repository at this point
Copy the full SHA 74caf14View commit details -
This reverts commit 42cd33d8d0efb236cc81f94f48d57efb0e1fca19.
Configuration menu - View commit details
-
Copy full SHA for 397659e - Browse repository at this point
Copy the full SHA 397659eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 097d2f5 - Browse repository at this point
Copy the full SHA 097d2f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ae88c2 - Browse repository at this point
Copy the full SHA 4ae88c2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.