Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break formatting #917

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Break formatting #917

wants to merge 7 commits into from

Commits on Jan 13, 2024

  1. Produce DWARF4 by default

    Have a look at the following commit to see when the move from DWARF 4 to 5 first happened upstream:
    
    llvm@d3b26de?diff=unified
    kwk authored and tstellar committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    035d412 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. [workflows] Split pr-code-format into two parts to make it more secure

    Actions triggered by pull_request_target events have access to all
    repository secrets, so it is unsafe to use them when executing
    untrusted code.  The pr-code-format workflow does not execute
    any untrusted code, but it passes untrused input into clang-format.
    An attacker could use this to exploit a flaw in clang-format and
    potentially gain access to the repository secrets.
    
    By splitting the workflow, we can use the pull_request target which
    is more secure and isolate the issue write permissions in a separate
    job.  The pull_request target also makes it easier to test changes
    to the code-format-helepr.py script, because the version of the
    script from the pull request will be used rather than the
    version of the script from main.
    tstellar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    014876f View commit details
    Browse the repository at this point in the history
  2. XXX: Debug

    tstellar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1ed7823 View commit details
    Browse the repository at this point in the history
  3. Break formatting

    tstellar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    74caf14 View commit details
    Browse the repository at this point in the history
  4. Revert "Break formatting"

    This reverts commit 42cd33d8d0efb236cc81f94f48d57efb0e1fca19.
    tstellar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    397659e View commit details
    Browse the repository at this point in the history
  5. Break formatting

    tstellar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    097d2f5 View commit details
    Browse the repository at this point in the history
  6. Revert "Break formatting"

    This reverts commit 097d2f5.
    tstellar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4ae88c2 View commit details
    Browse the repository at this point in the history