Add rpaas debug feature with custom image #136
Conversation
| &cli.BoolFlag{ | ||
| Name: "interactive", | ||
| Aliases: []string{"I", "stdin"}, | ||
| Usage: "pass STDIN to container", | ||
| }, | ||
| &cli.BoolFlag{ | ||
| Name: "tty", | ||
| Aliases: []string{"t"}, | ||
| Usage: "allocate a pseudo-TTY", | ||
| }, |
There was a problem hiding this comment.
I'd force the interactive mode (tty + interactive) in this sub-command... I think there's no other user case to use it without an interactive session.
| if status.State.Terminated != nil { | ||
| req := m.kcs.CoreV1().Pods(instance.Namespace).GetLogs(args.Pod, &corev1.PodLogOptions{Container: debugContainerName}) | ||
| return logs.DefaultConsumeRequest(req, args.Stdout) |
There was a problem hiding this comment.
It's possible I overlooked something however I really didn't get it... Why should we see the logs if pod is the termination phase?
There was a problem hiding this comment.
Cause it's possible to send a command and not enter in interact mode with debug container. In this case scenario container enter in terminated state and code throw to user container logs related to the command sent (this feature its similar how kubectl debug works in this scenario)
| @@ -0,0 +1,165 @@ | |||
| package web | |||
Co-authored-by: Claudio Netto <[email protected]>
Co-authored-by: Claudio Netto <[email protected]>
cmd/plugin/rpaasv2/cmd/debug.go
Outdated
| if nerr != nil { | ||
| closeErr, ok := nerr.(*websocket.CloseError) | ||
| if !ok { | ||
| done <- fmt.Errorf("ERROR: receveid an unexpected error while reading messages: %w", err) |
There was a problem hiding this comment.
Small typo:
"ERROR: received an unexpected..."
No description provided.