Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AlexMost
Been using ttag recently, was disappointed gettext couldn't support my Javascript/Typescript codebase.
Just experimenting with the babel plugins, not written any babel plugins before so your feedback would be very helpful 🙏
Changes to
/src
My thinking is that if we've got a
ImportDeclaration
which passes theif (!isTtagImport(node)) return;
then we cna be pretty sure there is an intent from the developer to be usingttag
for localization.Rather than throwing
You should use ttag imports in form: "import { t } from \'ttag\'"
we can import the default alias names so that we can catcht, gettext, ngettext,...
Tests added
[Will update..]