New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite while-loop bug when minifying CSS with unclosed body block #59

Closed

brandonkelly wants to merge 1 commit into tubalmartin:master from brandonkelly:patch-1

brandonkelly commented Apr 14, 2020

This PR fixes #58 by checking if $blockEndPos is false, and if so, throwing an InvalidArgumentException.


          Make sure $blockEndPos isn't false

62d8058

Fixes tubalmartin#58

brandonkelly mentioned this pull request

Memory leak issue injecting invalid CSS into view craftcms/cms#5912

Closed

Author

brandonkelly commented Apr 14, 2020

Just realized another proposed fix already exists for this bug (#49), so will close this.

brandonkelly closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet