Oplogtoredis: performance improvements by raw oplog processing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eparker-tulip
changed the title
eparker-tulip
changed the title
eparker-tulip
requested review from
alex-goodisman,
torywheelwright and
aranair
byronwasti
reviewed
Sep 30, 2024
torywheelwright
approved these changes
Oct 1, 2024
torywheelwright
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oplogtoredis receives the oplog entries, unmarshals the metadata layer for filtering/sharding, then unmarshals the payload and constructs an object that is then marshalled into JSON.
This PR skips the payload unmarshalling, and instead extracts the needed values directly from the bson.Raw object, using the methods provided with https://pkg.go.dev/go.mongodb.org/mongo-driver/bson . This is expected to be much more CPU/memory efficient than the former intermediate step of unmarshalling to a go object.