Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade CKAN to version 2.11.0 #70

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aleksandralazoroska
Copy link
Collaborator

This PR includes updates to the SDDI base for CKAN 2.11.0 along with the following key changes:

  • Updated the CKAN version to 2.11.0 in the sddi-base image.
  • Added required extensions as specified in Issue CKAN 2.11 and official base image support #64, integrating them into the environment.
  • Added necessary configurations for extensions, ensuring compatibility with the sddi-base.
  • Removed unsupported plugins and optimized the Docker build process to align with CKAN 2.11.0 standards and the sddi setup.

@BWibo
Copy link
Member

BWibo commented Nov 7, 2024

Hey @aleksandralazoroska @ilchebedelovski
Did you notice what @MarijaKnezevic wrote here: #69 (comment)

There is a good chance, that ckanext-spatial will work with the official CKAN v2.11 base image now, becuase it's based on Debian. For us it is really important to keep the future maintenance effort as low as possible. Hence, it is a almost a requirement to build upon the official image.

Moreover, as you can see below, this is mostly the same as the CKAN guys implement the official Dockerfiles. There is no need to re-invent the wheel.

https://github.com/ckan/ckan-docker-base/blob/02dc5317fbe618726acf5cec45ad803b44696528/ckan-2.11/base/Dockerfile#L1-L12

I suggest we open a new branch and PR to try this out. If we can't get it working, we can continue work here.
@MarijaKnezevic Is that OK with you?

@ilchebedelovski
Copy link
Collaborator

Yes sure @BWibo we will implement that and I will let you know once it is implemented.

We will add your name in the reviewers list once the PR is ready for a review, in the meantime we are fixing issues step by step in the Dockerfile, then test them in Kubernetes.

@BWibo
Copy link
Member

BWibo commented Nov 7, 2024

Thx @ilchebedelovski, sounds good.
I just wanted to make sure Marijas message was received and did not get lost due to the closed PR.

@MarijaKnezevic
Copy link
Collaborator

@BWibo I saw that you had prepared a branch for feature/official-ckan-2.11 and based on that I tested the official CKAN image and it works and builds the (the most important and critical) plugins without any problems. I tested it with docker compose,
I informed @ilchebedelovski about this already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants